-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FDC3 For Web Browsers Implementation #1309
Conversation
bd27747
to
e2a8a55
Compare
This comment was marked as outdated.
This comment was marked as outdated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewing the addon and fdc3-agent-proxy package. More reviews to come...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviews for the fdc3-get-agent package
packages/fdc3-get-agent/test/step-definitions/desktop-agent.steps.ts
Outdated
Show resolved
Hide resolved
packages/fdc3-get-agent/test/step-definitions/desktop-agent.steps.ts
Outdated
Show resolved
Hide resolved
packages/fdc3-get-agent/test/step-definitions/desktop-agent.steps.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just starting a review - have only really got through addon
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
toolbox/fdc3-for-web/fdc3-web-impl/test/features/raise-intent.feature
Outdated
Show resolved
Hide resolved
toolbox/fdc3-for-web/fdc3-web-impl/test/features/raise-intent.feature
Outdated
Show resolved
Hide resolved
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
At least it's helping me persuade myself to buy a bigger laptop (rendering the diff takes some doing) ;-) It's also a huge contribution of work to the standard which will have a massive positive impact on it if you/we pull it off. Looking forward to helping get that done. |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
3 similar comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM again (after fixing fdc3-workbench linter config)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see comments for issues I found.
@robmoffat are you ok to own resolving @novavi's comments? I shouldn't push currently as that will invalidate review and cause some CLA issues) |
I can go through a bunch and add these tomorrow. It can be a good way to help participate in this PR as I'm limited in what I can review. |
awesome thanks Brian |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@novavi can you please check @bingenito's commits fix your outstanding review issues and we can get this merged? thanks, |
Agreed at Maintainers meeting 12/02/25 that all requested changes had been applied and that we should go ahead and merge
Implementation PR for FDC3 for the Web (#896)
This PR primarily implements the
getAgent()
function (in the fdc3-get-agent package) as defined by the FDC3 Web Connection Protocol (WCP) and aDesktopAgentProxy
(in the fdc3-agent-proxy package) that it uses to implement communication with browser-based Desktop Agents via the FDC3 Desktop Agent Communication Protocol (DACP).Additionally, the FDC3 repository is refactored to be a monorepo supported by
npm workspaces
. The existing repository was split into fdc3-context (context type definitions), fdc3-schems (bridging and DACP protocol messages) and fdc3-standard (existing API TypeScript definitions, Intents and App Directory) packages. A testing package was added with tooling used in multiple packages for testing.These packages are rolled up for release on NPM by an fdc3 package (publishing to the existing @finos/fdc3 NPM package). Previous releases provided both ES6 and CommonJs modules within a single package - this release will only provide ES6, with a separate fdc3-commonjs module provided for backwards compatibility (will release at @finos/fdc3-commonjs).
Finally, a reference implementation, demo for FDC3 in a Web Browser and reference channel selector and intent resolver UIs (that can be injected into an app by getAgent) are provided in the toolbox/fdc3-for-web package.